On Mon, 2011-08-22 at 11:27 +0300, Tomi Valkeinen wrote:
> Use strtobool and kstrto* functions when parsing sysfs inputs.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx>
> ---
> drivers/video/omap2/dss/display.c | 21 +++++++++------------
> drivers/video/omap2/dss/manager.c | 37 +++++++++++++++++++------------------
> drivers/video/omap2/dss/overlay.c | 7 +++----
> 3 files changed, 31 insertions(+), 34 deletions(-)
<snip>
> diff --git a/drivers/video/omap2/dss/overlay.c b/drivers/video/omap2/dss/overlay.c
> index a95f25e..b2a5685 100644
> --- a/drivers/video/omap2/dss/overlay.c
> +++ b/drivers/video/omap2/dss/overlay.c
> @@ -211,17 +211,16 @@ static ssize_t overlay_enabled_show(struct omap_overlay *ovl, char *buf)
> static ssize_t overlay_enabled_store(struct omap_overlay *ovl, const char *buf,
> size_t size)
> {
> - int r, enable;
> + int r;
> + bool enable;
> struct omap_overlay_info info;
>
> ovl->get_overlay_info(ovl, &info);
>
> - r = kstrtoint(buf, 0, &enable);
> + r = strtobool(buf, &enable);
> if (r)
> return r;
>
> - info.enabled = !!enable;
> -
> r = ovl->set_overlay_info(ovl, &info);
> if (r)
> return r;
Oops. This removes the lines that write the new value to overlay_info,
thus making it impossible to change the enable-status. I'll fix this.
Tomi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
