Hi Ohad, On Thu, Aug 18, 2011 at 2:01 PM, Ohad Ben-Cohen <ohad@xxxxxxxxxx> wrote: > Hi Hiroshi, > > On Thu, Aug 18, 2011 at 1:49 PM, Hiroshi DOYU <Hiroshi.DOYU@xxxxxxxxx> wrote: >>> -extern void iommu_set_twl(struct iommu *obj, bool on); >> >> This function was introduced by "Hari Kanigeri" for some OMAP4 case, >> which is only using TLB, not H/W table walk. > > We discussed that internally, and concluded it's not needed anymore. I > still kept the underlying plumbing mechanism, just in case it'd still > be needed for some hw quirks in the future, but removed the interface > (in case a future hw revision will seem to need it, it would probably > make more sense to invoke the relevant mechanism from the underlying > layers rather than from a higher layer). > >>> -extern int iommu_set_da_range(struct iommu *obj, u32 start, u32 end); >> >> This function was introduced by "David Cohen" to specify the available >> ISP virtual address range. This function wasn't actually introduced by me, but I remember to refer it when I was discussing to not define address 0x0 as valid in da range by default (unless intentionally specified by client). > > Not sure if David or anyone is using this, but if someone is, it must > be out-of-tree. I am fine to remove it. Br, David > > In that case, even if it is needed, adding a mainline user for this > function at this point will most likely not be accepted anymore, and > instead, one will be suggested to use (and extend as necessary) the > DMA-API. > > Thanks, > Ohad. > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
