Re: [PATCH] usb: musb: fix pm_runtime calls while atomic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 12, 2011 at 8:50 AM, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, 12 Aug 2011, Vikram Pandita wrote:
>
>> From: Vikram Pandita <vikram.pandita@xxxxxx>
>>
>> musb pm_runtime_get_sync call happens in intrrupt context on cable attach case
>> That can result in re-enabling the interrupts and cause side affects.
>>
>> So move the code to a work queue.
>
> Instead of creating your own, new work queue, just use the pre-existing
> PM work queue.  In other words, replace pm_runtime_get_sync() with
> pm_runtime_get().

In this case it may not work, because immediately after a
pm_runtime_get_sync(),
we are going to access MUSB registers and xxx_sync()  call ensures we
will not abort.


>
> Alan Stern
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux