On 8/9/2011 9:51 PM, Russell King - ARM Linux wrote:
On Tue, Aug 09, 2011 at 11:23:20AM +0200, Cousson, Benoit wrote:
Hi Grant,
Trying to bind hwmod informations with DT, I'm facing a little limitation.
A bunch of drivers are using the platform_get_resource_byname, so the
name for the resource is needed.
The name is used so far for IORESOURCE_MEM, IORESOURCE_IRQ and
IORESOURCE_DMA types of resources.
Do you have any plan to add that, or do you have any clean way to avoid
that without having to use the resource index?
Named resources are evil. You only have to look at /proc/iomem to see
why that's the case. Here's an example:
b7a01000-b7a01003 : set
b7a01000-b7a01003 : set
So what? That just shows that /proc/iomem outputs sucks, but that does
not prove that named resources are evil.
[...]
How very informative. Not. So what device owns those? Who knows,
that's lost by the crappy named resource stuff.
Maybe, but this is not lost by the platform_device, and this is what
really matters in this case.
We need to get the resource local to a device, we do not care about the
global view. This is exactly what the platform_get_resource_byname is doing.
For my point of view, the need for that is similar to the clkdev /
clk_get(dev, name) you did. For sure, in that case, the real global
clock name is still relevant, but the important point for the driver is
the local device name.
Not providing the name of the resource will give you the device name,
but how informative is that for the driver? What entry is the good one
in the middle of that list?
b7a01040-b7a01043 : omap_foo
b7a01044-b7a01047 : omap_foo
b7a01048-b7a0104b : omap_foo
b7a01060-b7a01063 : omap_foo
Bottom-line, in both cases, /proc/iomem sucks... But who cares about the
internal representation? A platform_driver can still take advantage of
that, and this is exactly what we are looking for.
Benoit
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
