Hi,
On Friday 05 August 2011 02:13 PM, Semwal, Sumit wrote:
On Fri, Aug 5, 2011 at 8:42 AM, Archit Taneja<archit@xxxxxx> wrote:
Add support for VIDEO3 pipeline on OMAP4:
- Add VIDEO3 pipeline information in dss_features and omapdss.h
- Add VIDEO3 pipeline register coefficients in dispc.h
- Create a new overlay structure corresponding to VIDEO3.
Signed-off-by: Archit Taneja<archit@xxxxxx>
---
<snip>
- u32 fifo_size[3];
+ u32 fifo_size[MAX_DSS_OVERLAYS];
Do you think it makes some sense in splitting the 'generalisation'
like this that you've done in the patch from the xxx_VIDEO3 changes?
Yes, I could make a small patch which replaces "3" with
MAX_DSS_OVERLAYS, and the patch which introduces VIDEO3 pipe will
increase the macro value from 3 to 4.
Thanks,
Archit
It might make it look a little cleaner; otherwise the changes look
good to me; feel free to add my reviewed-by. [and to other patches in
this series].
<snip>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
