Hi Kevin
On Thu, 4 Aug 2011 08:45:10 -0700
Kevin Hilman <khilman@xxxxxx> wrote:
> For converting from struct device to platform_device, and from
> platform_device to struct omap_device, there are existing macros. Use
> them instead of manual use of container_of().
>
> Signed-off-by: Kevin Hilman <khilman@xxxxxx>
> ---
> arch/arm/plat-omap/mcbsp.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/plat-omap/mcbsp.c b/arch/arm/plat-omap/mcbsp.c
> index 3c1fbdc..47016f7 100644
> --- a/arch/arm/plat-omap/mcbsp.c
> +++ b/arch/arm/plat-omap/mcbsp.c
> @@ -260,9 +260,9 @@ EXPORT_SYMBOL(omap_mcbsp_dma_reg_params);
> #ifdef CONFIG_ARCH_OMAP3
> static struct omap_device *find_omap_device_by_dev(struct device *dev)
> {
> - struct platform_device *pdev = container_of(dev,
> - struct platform_device, dev);
> - return container_of(pdev, struct omap_device, pdev);
> + struct platform_device *pdev = to_platform_device(dev);
> +
> + return to_omap_device(pdev);
> }
>
I have a better alternative (that removes these unused lines) here:
http://marc.info/?l=linux-omap&m=130951039226392&w=2
I'm fine if you need to take my patch if there's urgent need to modify
these lines or otherwise I can carry it when sending an updated version
of my earlier McBSP cleanup set.
--
Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
