Re: [PATCH 2/4] Fixes for "input: Add initial support for TWL6040 vibrator"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, Aug 02, 2011 at 02:28:42PM +0300, Peter Ujfalusi wrote:
> @@ -145,7 +143,7 @@ static int vibra_play(struct input_dev *input, void *data,
>  
>  	ret = queue_work(info->workqueue, &info->play_work);
>  	if (!ret) {
> -		dev_err(&input->dev, "work is already on queue\n");
> +		dev_info(&input->dev, "work is already on queue\n");

why ???

>  		return ret;
>  	}
>  
> @@ -266,12 +264,10 @@ static int __devinit twl6040_vibra_probe(struct platform_device *pdev)
>  		goto err_irq;
>  	}
>  
> -	printk(KERN_ERR "%s:powering twl6040\n", __func__);
>  	ret = twl6040_power(info->twl6040, 1);
>  	if (ret < 0)
>  		goto err_pwr;
>  
> -	printk(KERN_ERR "%s:powered\n", __func__);

this hunk is not part of this patch.

>  	return 0;
>  
>  err_pwr:
> @@ -297,7 +293,6 @@ static int __devexit twl6040_vibra_remove(struct platform_device *pdev)
>  	twl6040_free_irq(info->twl6040, TWL6040_IRQ_VIB, info);
>  	input_unregister_device(info->input_dev);
>  	kfree(info);
> -	platform_set_drvdata(pdev, NULL);

neither is this.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux