On Tuesday, August 02, 2011, Jean Pihet wrote: > Rafael, > > 2011/7/29 Rafael J. Wysocki <rjw@xxxxxxx>: > > On Thursday, July 28, 2011, jean.pihet@xxxxxxxxxxxxxx wrote: > >> From: Jean Pihet <j-pihet@xxxxxx> > >> > >> The PM QoS implementation files are better named > >> kernel/pm_qos.c and include/linux/pm_qos.h. > >> > ... > > >> create mode 100644 include/linux/pm_qos.h > >> delete mode 100644 include/linux/pm_qos_params.h > > > > That I agree with. > > > >> create mode 100644 kernel/pm_qos.c > >> delete mode 100644 kernel/pm_qos_params.c > > > > As I said, please move that file to kernel/power and call it qos.c. > Ok > > > > > That said the device interface should be located in drivers/base/power > > to follow our current conventions. > By device interface I understand the following: > - the user space API (per-device sysfs entry), > - the in-kernel device specific PM QoS API. If needed, cf. comments on > [04/13] about that. > > Is that correct? Yes, it is. I think that the definitions of the dev_pm_qos_*() funtions mentioned in there may go into drivers/base/power/qos.c and they can call functions from kernel/power/qos.c. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
