Hi, On Wed, Jul 20, 2011 at 09:48:53AM -0700, Pandita, Vikram wrote: > > This *today happens to be only UMS* is my exact point here. > > Can you guarantee no other function driver will ever expect only > > full packet xfers and treat short as errors ? > > > > We are trying to test if short_not_ok may not be needed at all. But > all gadgets need to be tested on MUSB for that. > We will need wider help from MUSB maintainer/author(anand g) to > determine if removing short_not_ok is fine on MUSB for _all_ gadgets. > > To be safe we only enable for UMS use case today that is definitely > working fine. > > Time for Maintainer/author to pitch in !! I'm thinking on allowing this patch to go in if nobody has really strong arguments against it. The real fix, though, would need a bigger re-write of the endpoint IRQ handling and that would need more time to write and stabilize. Together with the huge amount of HW issues MUSB has, it's quite a task (been there, done that). -- balbi
Attachment:
signature.asc
Description: Digital signature
