Re: [PATCH 01/11] PM: add a per-device wake-up latency constraints plist

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Rafael,

2011/7/2 Rafael J. Wysocki <rjw@xxxxxxx>:
> Hi,
>
> On Thursday, June 30, 2011, jean.pihet@xxxxxxxxxxxxxx wrote:
...

>> @@ -462,6 +463,7 @@ struct dev_pm_info {
>>       unsigned long           accounting_timestamp;
>>       void                    *subsys_data;  /* Owned by the subsystem. */
>>  #endif
>> +     struct plist_head       wakeup_lat_plist_head;
>>  };
>
> Please use a better name.  I mean, relly, the type implies that this is a
> plist head, so that doesn't need to appear in the field name too.  Also,
> the name is confusing, because "wakeup" may mean a couple of different things
> and it's not entirely clear what "lat" stands for.  So, I'd prefer something
> like
>
> +       struct plist_head       latency_constraints;
>
> or perhaps you can invent something even better.
I am OK with your suggestion and I will update the naming.

>
>>
>>  extern void update_pm_runtime_accounting(struct device *dev);
>>
>
> Thanks,
> Rafael

Thanks,
Jean

> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux