On Wed, Jul 13, 2011 at 06:53:45PM +0300, Tero Kristo wrote: > On Wed, 2011-07-13 at 16:40 +0200, Mark Brown wrote: > > I do strongly prefer the idiom of just registering all the regulators > > even if they're read only. > Number of available SMPS regulators is kind of board specific issue. > OMAP3 has 2 available, OMAP4 has 3. If we are using some custom powering > solution, we might have even different amounts for these. Right, but the interface to them is always there? > > No, this is bad. We *always* pay attention to the constraints the user > > set even if they're nuts or won't work, the machine driver has the final > > say on what is or isn't allowed on a given board. The mode setting is > > especially suspect as there's no mode support in the driver. > Just a clarification on this one that I have understood your comment > right... Do you mean that I should be checking the constraints user sets > more thoroughly to see if there is something bogus? I was looking at > some of the other regulator drivers and they seem to be fiddling with > the constraints in similar manner. No! You should *always* use the constraints the user has set, don't randomly add new permissions without them doing so. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
