Re: [PATCH] OMAP2+: PM: fix watchdog boot when runtime PM is disabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 12 Jul 2011, Kevin Hilman wrote:

> Paul's concern is valid, and could be addressed by making that init code
> actually check if the WDT is currently active (as suggested by the
> comment there.)
> 
> In the mean time, this simple fix should be applied to prevent a boot
> crash, IMO.

Thing is, applying this fix will cause crashes if the bootloader enables 
the watchdog, but the kernel does not.  It just trades one source of 
crashes for another.

The root cause of this problem is that the drivers are incorrectly relying 
on runtime PM to "enable" devices.  My personal opinion is that we should 
be doing what SSB, PCI, etc. do, and have a omap_device_enable() that is 
called by the driver.  Basically, we need a real omap_bus/omap_device.

Meanwhile, switching to lazy device reset as Tony suggested should mask 
the issue.  The patches for this are 95% done; the intention is to post 
them for early 3.2.  Or if people are really gung-ho, 3.1 rc.


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux