Hi,
On Sun, Jul 10, 2011 at 05:43:23AM -0600, Paul Walmsley wrote:
> On Sun, 10 Jul 2011, Felipe Balbi wrote:
>
> > On Sat, Jul 09, 2011 at 07:57:20PM -0600, Paul Walmsley wrote:
> > > Hello Hema, Felipe,
> > >
> > > Commits 208466dc10083e734a8af71d10f923ee4bff950c ("usb: otg:
> > > OMAP4430: Powerdown the internal PHY when USB is disabled") and
> > > fb91cde49c327ff957c55d91805bc6abda59b311 ("usb: musb: OMAP4430:
> > > Power down the PHY during board init") break compilation on OMAP2:
> > >
> > > LD .tmp_vmlinux1
> > > arch/arm/mach-omap2/built-in.o:(.data+0x7ce0): undefined reference to `omap4430_phy_init'
> > > arch/arm/mach-omap2/built-in.o:(.data+0x7ce4): undefined reference to `omap4430_phy_exit'
> > > arch/arm/mach-omap2/built-in.o:(.data+0x7ce8): undefined reference to `omap4430_phy_power'
> > > arch/arm/mach-omap2/built-in.o:(.data+0x7cec): undefined reference to `omap4430_phy_set_clk'
> > > arch/arm/mach-omap2/built-in.o:(.data+0x7cf0): undefined reference to `omap4430_phy_suspend'
> > > make: *** [.tmp_vmlinux1] Error 1
> > >
> > >
> > > Could you please figure out a clean way to fix this for the 3.1 rc series?
> >
> > Patch attached, if you want to queue it for the merge window.
>
> This patch doesn't build when based on the arm-soc omap/cleanup branch.
>
> arch/arm/mach-omap2/twl-common.c:55:19: error: 'omap4430_phy_set_clk'
> undeclared here (not in a function)
What on earth is arm-soc omap/cleanup branch ? I generally base my
patches off of Linus' tags. This one in particular was based off of
3.0-rc6 (or -rc5, can't quite remember). Where is this particular branch
I should base off ?
--
balbi
Attachment:
signature.asc
Description: Digital signature
