Hi,
On Saturday, July 09, 2011, Kevin Hilman wrote:
> Hi Rafael,
>
> Just curious why pm_runtime_suspended() requires the device to be
> enabled for it to return true:
>
> static inline bool pm_runtime_suspended(struct device *dev)
> {
> return dev->power.runtime_status == RPM_SUSPENDED
> && !dev->power.disable_depth;
> }
>
> I must be misunderstanding something, but I would consider a device that
> has been runtime suspended before runtime PM was disabled to still be
> runtime suspended.
The problem is that while the runtime PM of the device is disabled
(ie. dev->power.disable_depth > 0), its status may be switched from
RPM_SUSPENDED to RPM_ACTIVE on the fly, using pm_runtime_set_active()
(and the other way around) and it doesn't reflect the real status in
principle. So it was a tough choice what to do about that and I decided
to go with returning false (in many cases runtime PM disabled means the
device is always operational).
> I just noticed this when testing with your pm-domains branch. when I
> noticed that an 'if (pm_runtime_suspended(dev))' check in my PM domain's
> ->suspend_noirq() was always failing since it's after the PM core calls
> pm_runtime_disable(). I had to change my PM domain code to only check
> dev->power.runtime_status for it to work.
Well, at this point I'm kind of cautious about changing pm_runtime_suspended(),
so perhaps we need a separate callback returnig true in the status is
RPM_SUSPENDED regardless of the value of power.disable_depth, like
pm_runtime_status_suspended() or something similar.
Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
