On 06/07/11 12:11 PM, Premi, Sanjeev wrote: >> -----Original Message----- >> From: linux-omap-owner@xxxxxxxxxxxxxxx >> [mailto:linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of Raphaël Assénat >> Sent: Wednesday, July 06, 2011 8:59 PM >> To: linux-omap@xxxxxxxxxxxxxxx >> Subject: [PATCH] AM3505/3517 ZCN package support >> >> This patch adds support for the AM35xx ZCN package specific muxmodes. >> >> Signed-off-by: Raphael Assenat <raph@xxxxxx> >> > > [sp] Few quick comments below: Thank you for your comments. I just sent an updated version according to them. >> +#define _OMAP3_NULL_MUXENTRY(M0) _OMAP3_MUXENTRY(M0, 0, >> NULL, NULL, \ >> + NULL, NULL, NULL, NULL, NULL, NULL) >> + >> /* >> * Superset of all mux modes for omap3 >> */ >> @@ -651,51 +654,50 @@ static struct omap_mux __initdata >> omap3_muxmodes[] = { >> "gpio_166", NULL, NULL, "safe_mode"), >> >> /* Only on 3630, see omap36xx_cbp_subset for the signals */ >> - _OMAP3_MUXENTRY(GPMC_A11, 0, >> - NULL, NULL, NULL, NULL, >> - NULL, NULL, NULL, NULL), > [snip]...[snip] >> + _OMAP3_NULL_MUXENTRY(GPMC_A11), >> + _OMAP3_NULL_MUXENTRY(SAD2D_MBUSFLAG), >> + _OMAP3_NULL_MUXENTRY(SAD2D_MREAD), > > [sp] These changes don't go with the current patch description. > You may want to keep them in a separate patch; and use here. Ok, I will send another patch for this that will apply on top of the ZCN patch. Regards, Raphaël Assénat -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
