Hi
On Fri, 1 Jul 2011 16:41:23 +0530
"Varadarajan, Charulatha" <charu@xxxxxx> wrote:
> > @@ -712,7 +710,7 @@ static inline void omap34xx_mcbsp_free(struct omap_mcbsp *mcbsp)
> > /*
> > * Disable wakup behavior, smart idle and all wakeups
> > */
> > - if (cpu_is_omap34xx() || cpu_is_omap44xx()) {
> > + if (mcbsp->mcbsp_config_type >= MCBSP_CONFIG_TYPE3) {
>
>
> I think that it would be a good idea to not use
> MCBSP_CONFIG_TYPE* in plat-omap/* as it is the .rev info.
> At later point of time, this might make the code look uglier
> as it happened with GPIO_METHOD_* flags in OMAP GPIO driver.
> Instead use this .rev info in mach-omap*/ to fill the pdata and pass it
> to driver.
>
Exactly and this is already a little uggly here. Kind of simple
replacement for cpu_is_omap tests and definitely must be replaced with
some feature flags before moving code outside of plat-omap.
--
Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
