Hi On Mon, 27 Jun 2011, Benoit Cousson wrote: > The CLKCTRL register was accessed using an absolute address. > The usage of hardcoded macros to calculate virtual address from physical > one should be avoided as much as possible. > The usage of a offset will allow future improvement like migration from > the current architecture code toward a module driver. one minor comment below: > > Update cm_xxx accessor, move definition to the proper header file and > update copyrights. > > Signed-off-by: Benoit Cousson <b-cousson@xxxxxx> > Cc: Paul Walmsley <paul@xxxxxxxxx> > Cc: Rajendra Nayak <rnayak@xxxxxx> > --- > arch/arm/mach-omap2/cm44xx.h | 3 +- > arch/arm/mach-omap2/cminst44xx.c | 23 +++- > arch/arm/mach-omap2/cminst44xx.h | 4 +- > arch/arm/mach-omap2/omap_hwmod.c | 10 +- > arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 182 ++++++++++++++++--------- > arch/arm/plat-omap/include/plat/omap_hwmod.h | 2 +- > 6 files changed, 145 insertions(+), 79 deletions(-) > > diff --git a/arch/arm/mach-omap2/cm44xx.h b/arch/arm/mach-omap2/cm44xx.h > index 0b87ec8..cdda756 100644 > --- a/arch/arm/mach-omap2/cm44xx.h > +++ b/arch/arm/mach-omap2/cm44xx.h > @@ -1,7 +1,7 @@ > /* > * OMAP4 Clock Management (CM) definitions > * > - * Copyright (C) 2007-2009 Texas Instruments, Inc. > + * Copyright (C) 2007-2011 Texas Instruments, Inc. > * Copyright (C) 2007-2009 Nokia Corporation > * > * Written by Paul Walmsley > @@ -26,7 +26,6 @@ > /* Function prototypes */ > # ifndef __ASSEMBLER__ > > -extern int omap4_cm_wait_module_ready(void __iomem *clkctrl_reg); > > # endif > #endif > diff --git a/arch/arm/mach-omap2/cminst44xx.c b/arch/arm/mach-omap2/cminst44xx.c > index a482bfa..1df740e 100644 > --- a/arch/arm/mach-omap2/cminst44xx.c > +++ b/arch/arm/mach-omap2/cminst44xx.c > @@ -2,6 +2,7 @@ > * OMAP4 CM instance functions > * > * Copyright (C) 2009 Nokia Corporation > + * Copyright (C) 2011 Texas Instruments, Inc. > * Paul Walmsley > * > * This program is free software; you can redistribute it and/or modify > @@ -199,9 +200,20 @@ void omap4_cminst_clkdm_force_wakeup(u8 part, s16 inst, u16 cdoffs) > * > */ > > +static u32 _clkctrl_idlest(u8 part, u16 inst, s16 cdoffs, u16 clkctrl_offs) Maybe call this _read_clkctrl_idlest() to identify what it's doing? - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
