Re: [PATCHv2 2/3] MMC: OMAP: HSMMC: add runtime pm support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 30, 2011 at 10:01 AM, T Krishnamoorthy, Balaji
<balajitk@xxxxxx> wrote:
> On Wed, Jun 29, 2011 at 11:26 PM, Kevin Hilman <khilman@xxxxxx> wrote:
>> "T Krishnamoorthy, Balaji" <balajitk@xxxxxx> writes:
>>
>>> On Wed, Jun 29, 2011 at 5:02 AM, Kevin Hilman <khilman@xxxxxx> wrote:
>>>> +Rajendra
>>>>
>>>> Balaji T K <balajitk@xxxxxx> writes:
>>>>
>>>>> add runtime pm support to HSMMC host controller
>>>>> Use runtime pm API to enable/disable HSMMC clock
>>>>> Use runtime autosuspend APIs to enable auto suspend delay
>>>>>
>>>>> Based on OMAP HSMMC runtime implementation by Kevin Hilman, Kishore Kadiyala
>>>>>
>>>>> Signed-off-by: Balaji T K <balajitk@xxxxxx>
>>>>
>>>> I tried to test this series along with Benoit's clkdm/modulemode/hwmod
>>>> cleanups and something strange is happening on OMAP4.
>>>>
>>>> First, this series by itself is working as I would expect, but testing
>>>> in combination with Benoit's series, it's different...
>>>>
>>>> First, I'm using Benoit's branch:
>>>>
>>>>       git://gitorious.org/omap-pm/linux.git for_3.0.1/7_hwmod_modulemode
>>>>
>>>> in combination with your series.
>>>>
>>>> I've also reverted these two commits:
>>>>
>>>>   OMAP4: PM: TEMP: Prevent l3init from idling/force sleep
>>>>   OMAP3+: hwmod data: TEMP: Do not idle MMC1 & MMC2 after boot
>>>>
>>>> which are temporary workarounds for not having MMC runtime PM.
>>>>
>>>> I turned the dev_dbg calls in the runtime PM callbacks into dev_info
>>>> callbacks to see exactly when the device is enabled/disabled via runtime
>>>> PM.
>>>>
>>>> To my surprise, I didn't see the device being enabled/disabled when
>>>> writing do the device.
>>>
>>> I tried for_3.0.1/7_hwmod_modulemode as you mentioned above,
>>> changing dev_dbg to dev_err and I am not observing the delayed write
>>> during umount. Can you let me know if the files are there in MMC after
>>> remounting ?
>>
>> Did you also revert the above two commits?
>
> yes
>
>>
>> I've pushed a 'tmp/mmc' branch to my git tree[1] which is my PM branch
>> (including various PM stuff queued for upstream) as well as Benoit's
>> series with the TEMP patches above reverted and your series on top of
>> it.  There's one additional patch to convert the dev_dbg into dev_info
>> to see the transitions.
>>
>> Testing this on my OMAP4430 ES2.2 EMU device, I still see the above
>> behavior.
>
> I used OMAP4430 ES2.1 GP
>
>>
>> Can you try out this branch on your board using the default
>> omap2plus_defconfig?
>
> Ok, I will retry on EMU device.
Tried on ES2.1 EMU, log shared at http://pastebin.com/Umg2zF2J

Can you share your complete log?

>
>>
>> Thanks,
>>
>> Kevin
>>
>> [1] git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux