Hi,
On Tuesday 28 June 2011 09:58 PM, Valkeinen, Tomi wrote:
On Tue, 2011-06-28 at 09:19 -0700, Archit Taneja wrote:
Hi,
On Monday 27 June 2011 10:31 AM, Dima Zavin wrote:
There's no guarantee that the error handler worker thread
will run while the dispc clocks are on. Explicitly enable/disable
them.
I agree with this.
Yes, I think this patch is fine. I'll apply it to DSS tree.
Tomi,
We could get prevent scheduling of the error worker by registering
omap_dispc_irq_handler() as an interrupt thread.
But then we would get extra latency on the interrupt handlers. I wanted
to keep handling DSS interrupts in interrupt context, because some use
cases may require very fast reaction to an interrupt.
Okay..we don't need to handle the errors in interrupt context..the
request_threaded_irq() takes 2 functions I think, we could have have
omap_dispc_irq_handler() as the primary handler, and the error_worker as
the thread.
I think the change I'm just suggesting just leads to some beautification
in the end :), we would still need to ensure that clocks are enabled in
the error_worker path.
Archit
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
