On Tue, 2011-06-28 at 11:14 +0200, Cousson, Benoit wrote: > On 6/28/2011 10:29 AM, Valkeinen, Tomi wrote: > > My current pm_runtime patch set removes the omapdss clock aliases from > > arch/arm/mach-omap2/clock44xx_data.c, as the driver uses the opt-clock > > names. Isn't that correct way? > > Yes, it is, but we need to take care of the name. The names are local to > the device, so previously I had to prefix with dss_ every clocks > affected to the dss_core. Since now, most of them are connected only to > the relevant hwmod, we can use alias like "fck" if the role of the clock > is the functional one. Ok. > > The opt-clocks that my patch set gets are: > > > > - dss_clk > > So that one was the DSS PRCM modulemode and will not exist anymore. No, that was dss_dss_clk. It was named "dss_clk", as that is what the TRM's clock tree shows. All the names in my patch set are from the clock tree image. > > - sys_clk > > That one is OK. > > > - hdmi_clk > > I guess that one should be name "fck", since only the HDMI hwmod will > use it. Ok. So the names shouldn't be the ones in the TRM, but more general ones? > > - rfbi_iclk > > Should be named "ick", but I'm not even sure that one is needed. rfbi needs to know the rate of the clock, so it needs to clk_get() it. > > - tv_clk > > - tv_dac_clk > > Why do you have two clocks for the tv? I can only see the dss_tv_fclk in > the spec. OMAP3430 has a separate dac clock. > > Additionally these are used to configure the clk rates: > > - dpll4_m4_ck > > - dpll_per_m5x2_ck > > > > The "dss_clk" opt-clock is a bit of an odd-ball. The same clock is used > > as a main-clk and an opt-clock. The driver uses the clock to change the > > clock rates. If the driver can get the main-clock with some built-in > > alias, like "fck", then this opt-clock is not needed. But I wasn't aware > > of such a method. > > Maybe because I've just introduced it :-) > OMAP: omap_device: Create clkdev entry for hwmod main_clk > > It was not done like that before. Only the opt_clk were used, because > the main_clk was not relevant. With that series, the main_clk represents > real clock, and thus can be exposed with "fck" alias. Ok. This will allow removal of the "dss_clk" opt-clocks in my patch set. Tomi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
