Tony Lindgren <tony@xxxxxxxxxxx> writes: > * Tony Lindgren <tony@xxxxxxxxxxx> [110627 00:50]: >> * Kevin Hilman <khilman@xxxxxx> [110623 10:06]: >> > Tony Lindgren <tony@xxxxxxxxxxx> writes: >> > > + >> > > + res = omap_dm_timer_init_one(&clksrc, gptimer_id, fck_source); >> > >> > This function makes calls into "real" driver, but is called from >> > sys_timer.init so happens before driver is initialized. >> >> That one is the static omap2+ specific function that can be passed >> to the dmtimer device driver as a function pointer in the later >> patches. >> >> > > + omap_dm_timer_set_load_start(&clksrc, 1, 0); >> > >> > Here's another call into the real driver. I think you need >> > __omap_dm_timer_set_load_start() here. >> >> Thanks, that's correct. Will fix that one. > > Here's this one updated. Looks like I still have your Reviewed-by > lines from the last time this series got posted. Can you please check > if those are still valid? Yes, they're still valid as I've now been through the whole series. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html