Hi Paul, Here is an updated version of the series started by Rajendra. It takes into account comments from Todd. I had to update it because this series is mandatory for the hwmod modulemodule control series. I rebased it on top of the various fixes done on hwmod framework to take advantage of the new clkdm attribute in omap_hwmod. I thus added 2 new APIs to handle clockdomain from hwmod instead of using the clockdomain done for clock. I drop the clockdomain control for optional clocks because is not mandatory. On OMAP4, the PRCM recommended sequence for enabling a module after power-on-reset is: -1- Force clkdm to SW_WKUP -2- Configure desired module mode to "enable" or "auto" -3- Wait for the desired module idle status to be FUNC -4- Program clkdm in HW_AUTO(if supported) This sequence applies to all older OMAPs' as well, however since they use 'autodeps', it makes sure that no clkdm is in IDLE, and hence not requiring a force SW_WKUP when a module is being enabled. OMAP4 does not need to support autodeps, because of the dynamic dependency feature, wherein the HW takes care of waking up a clockdomain from idle and hence the module, whenever an interconnect access happens to the given module. Implementing the sequence for OMAP4 requires some of the clockdomain handling that is currently done in clock framework to be done as part of hwmod framework since the step -3- above to "Wait for the desired module idle status to be FUNC" is done as part of hwmod framework. This series moves the clockdomain handling into hwmod framework and implements the above sequence for OMAP4. Lastly, with this series drivers which are yet to be adapted to PM runtime and still rely on clock calls to enable/disable the respective *main* clocks are expected to be broken. MMC is one such which even breaks boot, and hence the series has a TEMP workaround patch added which keeps l3init clockdomain always force-enabled. This TEMP patch will gate all CORE low power transitions but should at least allow MPU low power transitions to work. The series is based on for_3.0.1/4_hwmod_modulemode and tested on OMAP4430 ES2.1 + SDP. It should not affect OMAP2 & 3, but some testing are definitively needed. The patches are available here: git://gitorious.org/omap-pm/linux.git for_3.0.1/5_hwmod_clkdm_fixes Regards, Benoit Changes since v1: http://www.spinics.net/lists/linux-omap/msg52265.html - Rebase series on top on modulemode series Changes since v2: http://www.spinics.net/lists/linux-omap/msg53111.html - Remove #ifdef - Rename clkdm_is_idle - Remove confusing pr_debug message in clkdm_xxx functions - Add per clkdm spinlock to avoid concurrent access Benoit Cousson (1): OMAP2+: clockdomain: Add 2 APIs to control clockdomain from hwmod framework Rajendra Nayak (7): OMAP2+: clockdomain: Add an api to read idle mode OMAP2+: clockdomain: Add SoC support for clkdm_is_idle OMAP2+: PM: Initialise sleep_switch to a non-valid value OMAP2+: PM: idle clkdms only if already in idle OMAP4: PM: TEMP: Prevent l3init from idling/force sleep OMAP2+: clockdomain: Add per clkdm lock to prevent concurrent state programming OMAP2+: hwmod: Follow the recommended PRCM module enable sequence arch/arm/mach-omap2/clock.c | 17 +--- arch/arm/mach-omap2/clockdomain.c | 193 +++++++++++++++++++++----- arch/arm/mach-omap2/clockdomain.h | 8 + arch/arm/mach-omap2/clockdomain2xxx_3xxx.c | 18 +++- arch/arm/mach-omap2/clockdomain44xx.c | 20 ++-- arch/arm/mach-omap2/clockdomains44xx_data.c | 2 +- arch/arm/mach-omap2/omap_hwmod.c | 26 ++++- arch/arm/mach-omap2/pm.c | 6 +- 8 files changed, 222 insertions(+), 68 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
