Kevin, [...] > > > > With register offsets now defined for respective OMAP versions we can > get rid > > of cpu_class_* checks. In addition, organized common initialization for > the > > different OMAP silicon versions. > > > > Signed-off-by: Charulatha V <charu@xxxxxx> > > Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@xxxxxx> > > Since the SYSCONFIG register settings are OMAP1-only and init-time only, > they could be done in the OMAP1-specific init functions. BTW, I needed some more clarifications here... The omap_gpio_mod_init() is called only once from _probe(). So, does it make sense to have a separate init function? If yes, I have to call __init omap1_gpio_mod_init() from _probe() again. This is because I need the bank information supplied to it. Let me know if this is a fair understanding. Thanks. -- Tarun > > Also, this could be quite a bit more compact by not duplicating code for > both bank widths. Instead, create some local function pointers for 16 > or 32-bit register access, and assign them based on bank width. > > Kevin > [...] -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
