> -----Original Message----- > From: Shilimkar, Santosh > Sent: Friday, June 24, 2011 6:18 PM > To: Premi, Sanjeev > Cc: linux-omap@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH 1/2] omap2+: pm: Use if...else instead of goto > > On 6/24/2011 4:05 PM, Sanjeev Premi wrote: > > This patch replaces the use of goto with simple > > if...else syntax. No change in functionality. > > > > This also means that the comment describing the > > dependency between CONFIG_SMP and calculation > > of loops_per_jiffy can be unified. > > > > Signed-off-by: Sanjeev Premi<premi@xxxxxx> > > --- > Don't see need of this patch as well considering your second patch. > So NAK. > [sp] May be it isn't needed - but it surely highlights some bad code that does find way upstream. ~sanjeev-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html