On 24 June 2011 11:52, Munegowda, Keshava <keshava_mgowda@xxxxxx> wrote: > On Fri, Jun 24, 2011 at 2:31 AM, Jassi Brar <jassisinghbrar@xxxxxxxxx> wrote: >> The commit >> 7e6502d577106fb5b202bbaac64c5f1b065 'mfd: Add omap-usbhs runtime PM support' >> besides moving to RPM, removes necessary TLL initialization as well. >> >> Restore the TLL initialization, without which device detection fails. >> >> Signed-off-by: Jassi Brar <jaswinder.singh@xxxxxxxxxx> > > if you move to RPM, you should'tn access these configuration/reset > registers in your driver. Sorry I don't get it. Obviously the RPM backend here doesn't initialize the TLL and if it only manages the clocks, can't we safely assume that the pm_runtime_get_sync will get clocks to speed and the driver does the TLL init ? > moreover, the patch 'mfd: Add omap-usbhs runtime PM support' is > already reverted. Ok, though if the ultimate goal is to move on to RPM, this would be a step back. Btw, which tree could I find the revert in ? Thanks, Jassi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html