Kevin Hilman <khilman@xxxxxx> writes:
> Tony Lindgren <tony@xxxxxxxxxxx> writes:
>
>> Use dmtimer macros for clocksource. As with the clockevent,
>> this allows us to initialize the rest of dmtimer code later on.
>>
>> Note that eventually we will be initializing the timesource
>> from init_early so sched_clock will work properly for
>> CONFIG_PRINTK_TIME.
>>
>> Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
>> Reviewed-by: Kevin Hilman <khilman@xxxxxx>
>
> [...]
>
>> +/* Setup free-running counter for clocksource */
>> +static void __init omap2_gp_clocksource_init(int gptimer_id,
>> + const char *fck_source)
>> +{
>> + int res;
>> +
>> + res = omap_dm_timer_init_one(&clksrc, gptimer_id, fck_source);
>> + BUG_ON(res);
>
> This is a change from previous code where the clocksource was requesting
> any timer, not a specific one.
>
> Also, you're using the same gptimer_id here as the clockevent, which
> means this is guaranteed to fail.
Nevermind, ignore this comment.
I misread the macros.
Sorry for the noise.
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
