On 6/20/2011 8:31 PM, Russell King - ARM Linux wrote:
On Mon, Jun 20, 2011 at 08:24:33PM +0530, Santosh Shilimkar wrote:
I am away from my board now. Will test this change.
btw, the online-active race is still open even with this patch close
and should be fixed.
I have yet to see any evidence of that race - I've been running your
test loop for about an hour so far on Versatile Express and nothing
yet.
In that case my script was just exposing the calibrate() code race
condition.
That's not to say that we shouldn't wait for the active mask to become
true before calling schedule(), but I don't think its as big a deal as
you're suggesting it is.
I am not expert to really trigger that exact race online-to-active but
am sure the race needs to be fixed.
May be Thomas can suggest a test-case to expose that race. From
his fix for x86, it appeared that the race was indeed hit in some
sequence.
Regards,
Santosh
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
