On Mon, 2011-06-20 at 16:16 +0530, Tushar Behera wrote: > In certain board files, there are references to vram related functions > which are defined in drivers/video/omap2/vram.c. Because of this direct > dependency, CONFIG_FB_OMAP2 should be a built-in feature. arch/arm/plat-omap/include/plat/vram.h defines dummy inline function in case vram.c is not compiled in, so the board files should compile fine. > As per the current architecture, CONFIG_FB_OMAP2 is dependent on > CONFIG_OMAP2_DSS. Hence CONFIG_OMAP2_DSS support should also be selected > by default. The configuration is fine as it is. And anyway, if things do not compile when something is configured as a module, the correct fix is hardly just changing the feature to be compiled built-in =). > Cc: Tony Lindgren <tony@xxxxxxxxxxx> > Cc: Samreen <samreen@xxxxxx> > Signed-off-by: Tushar Behera <tushar.behera@xxxxxxxxxx> > --- > arch/arm/mach-omap2/built-in.o: In function `rx51_video_mem_init': > linux-linaro-2.6.39/arch/arm/mach-omap2/board-rx51-video.c:97: undefined reference to `omap_vram_set_sdram_vram' > arch/arm/plat-omap/built-in.o: In function `omap_reserve': > linux-linaro-2.6.39/arch/arm/plat-omap/common.c:66: undefined reference to `omap_vram_reserve_sdram_memblock' > arch/arm/plat-omap/built-in.o: In function `omap_detect_sram': > linux-linaro-2.6.39/arch/arm/plat-omap/sram.c:179: undefined reference to `omap_vram_reserve_sram' > make[1]: *** [.tmp_vmlinux1] Error 1 > make: *** [sub-make] Error 2 Compiles fine for me. Perhaps you are using some old kernel? Tomi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
