Re: [PATCH] ARM: OMAP: Overo: remove illegal extra call to overo_ads7846_init()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Daniel Mack <zonque@xxxxxxxxx> writes:

> Signed-off-by: Daniel Mack <zonque@xxxxxxxxx>

Thanks for fixing this, I noticed this recently too.

Please add a descriptive changelog.  For example, why is it duplcate?
where is it already done?  what commit added the extra call, what
problems does it cause, etc.

Also, your subject says 'illegal', but it's not really illegal.  It's just
wrong. :)   "remove duplcate call to..." is enough.

Thanks,

Kevin


> ---
>  arch/arm/mach-omap2/board-overo.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-overo.c b/arch/arm/mach-omap2/board-overo.c
> index 175e1ab..110475f 100644
> --- a/arch/arm/mach-omap2/board-overo.c
> +++ b/arch/arm/mach-omap2/board-overo.c
> @@ -568,7 +568,6 @@ static void __init overo_init(void)
>  	usb_musb_init(NULL);
>  	usbhs_init(&usbhs_bdata);
>  	overo_spi_init();
> -	overo_ads7846_init();
>  	overo_init_smsc911x();
>  	overo_display_init();
>  	overo_init_led();
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux