Kevin Hilman wrote: > Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxxxxxxxxxxxxx> writes: > >> Hi Kevin and Felipe, >> >> Kevin Hilman wrote: >>> In commit 7538e3db6e015e890825fbd9f8659952896ddd5b (PM: add support >>> for device power domains) a better way for handling platform-specific >>> power hooks was introduced. >>> >>> Rather than using the platform_bus dev_pm_ops overrides >>> (platform_bus_set_pm_ops()), this patch moves the OMAP runtime PM >>> implementation over to using device power domains. >>> >>> Since OMAP is the only user of platform_bus_set_pm_ops(), that >>> interface can be removed (and will be in a forthcoming patch.) >> >> I have little doubt of the correctness of the patch itself, but it >> actually does break the USB on N900. I don't know PM so well that I >> would have a good idea what might be going wrong here, so I'm not >> certain that this is specific to the N900 either. >> >> It looks strange to me also but I've tested it several times so I'm >> fairly certain that the culprit is this very patch. :-) > > You're correct, it's broken. > > A fix has been posted (and pull req sent to Tony.) Can you try my > for_3.0/pm-fixes branch which fixes this problem? It's available in my > git tree: > > git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git Hi, Kevin! Many thanks to you! :-) The patches indeed fix the problem. I seem to have used for_3.0/pm-fixes-2 branch, though. I guess that doesn't really matter. :-) Cheers, -- Sakari Ailus sakari.ailus@xxxxxxxxxxxxxxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html