On Tue, Jun 7, 2011 at 10:04 AM, Kevin Hilman <khilman@xxxxxx> wrote: > Grant Likely <grant.likely@xxxxxxxxxxxx> writes: > >> On Mon, Jun 6, 2011 at 5:18 PM, Kevin Hilman <khilman@xxxxxx> wrote: >>> Hi Colin, >>> >>> Colin Cross <ccross@xxxxxxxxxxx> writes: >>> >>>> Setting the IRQWAKEN bit was overwriting previous IRQWAKEN bits, >>>> causing only the last bit set to take effect, resulting in lost >>>> wakeups when the GPIO controller is in idle. >>>> >>>> Replace direct writes to IRQWAKEN with MOD_REG_BIT calls to >>>> perform a read-modify-write on the register. >>>> >>>> Signed-off-by: Colin Cross <ccross@xxxxxxxxxxx> >>> >>> Thanks, I'll queue these both for Grant for the 3.0-rc fixes along with >>> another GPIO fix for a section mismatch I have queued. >>> >>> Minor: now that this driver has moved to drivers, I changed the subject >>> prefixes slightly. They now read: >>> >>> GPIO: OMAP: fix setting IRQWAKEN bits for OMAP4 >>> GPIO: OMAP: add locking around calls to _set_gpio_triggering >> >> If you're collecting fixes for Linus anyway, go ahead and add my a-b >> line and include these two to send on to Linus >> >> Acked-by: Grant Likely <grant.likely@xxxxxxxxxxxx> >> >> Or, if they are only gpio fixes, then I'd also be happy to get a git >> pull req for the changes. :-) >> > > I have a GPIO-only queue, so I'll have a pull req for you today. thx. g. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
