Hi Laurent, On Tue, Jun 7, 2011 at 12:05 PM, Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > pgsz isn't used anymore, you can remove it. Ok. >> + order = get_order(bytes); > > Does iommu_map() handle offsets correctly, or does it expect pa to be aligned > to an order (or other) boundary ? Right now we have a BUG_ON if pa is unaligned, but that can be changed if needed (do we want it to handle offsets ?). > As Russell pointed out, we should use sg->length instead of sg_dma_length(sg). > sg_dma_length(sg) is only valid after the scatter list has been DMA-mapped, > which doesn't happen in the iovmm driver. This applies to all sg_dma_len(sg) > calls. I'll make sure I don't introduce such calls, but it sounds like a separate patch should take care of the existing ones; pls tell me if you want me to send one. Thanks, Ohad. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
