On Sun, Jun 05, 2011 at 03:30:55PM -0400, Alan Stern wrote: > On Sun, 5 Jun 2011, Felipe Balbi wrote: > > that would mean changes to all linker scripts, though and a utility call > > that only does anything ifndef CONFIG_PM to free the .pm.ops section. > In my opinion this would make programming harder, not easier. It's > very easy to understand "#ifdef" followed by "#endif"; people see them > all the time. The new tags you propose would force people to go > searching through tons of source files to see what they mean, and then > readers would still have to figure out when these tags should be used > or what advantage they might bring. The big advantage is that they make it much harder to introduce random build breakage and they're an awful lot less fiddly to do - it used to be not so bad when it was just the function pointers that needed to be defined to NULL but now we need to faff around with both the functions and the dev_pm_ops. The annotation approach is already familiar from the init stuff so it wouldn't be so hard for people to understand. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
