> -----Original Message----- > From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- > owner@xxxxxxxxxxxxxxx] On Behalf Of Shilimkar, Santosh > Sent: Monday, June 06, 2011 12:32 PM > To: Colin Cross > Cc: linux-omap@xxxxxxxxxxxxxxx; Tony Lindgren; Russell King; linux- > kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH] ARM: omap4: gpio: fix setting IRQWAKEN bits > > On 6/5/2011 12:33 AM, Colin Cross wrote: > > Setting the IRQWAKEN bit was overwriting previous IRQWAKEN bits, > > causing only the last bit set to take effect, resulting in lost > > wakeups when the GPIO controller is in idle. > > > > Replace direct writes to IRQWAKEN with writes to SETWKUENA and > > CLEARWKUEN. > > > > Signed-off-by: Colin Cross<ccross@xxxxxxxxxxx> > > Looks good. This needs to be fixed on top of the clean-up > branch where GPIO movemnt to driver/gpio/* happening. > > For this change, > Acked-by: Santosh Shilimkar <santosh.shilimkar@xxxxxx> This is also available as part of following cleanup series we are doing. However, since this is a defect we can prioritize it over the cleanup. -- Tarun > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
