Hi Ohad, On Wednesday 01 June 2011 18:39:46 Ohad Ben-Cohen wrote: > Fix a potential NULL pointer dereference by skipping registration of > external entities in case none are provided. > > This is useful at least when testing mere memory-to-memory scenarios. > > Signed-off-by: Ohad Ben-Cohen <ohad@xxxxxxxxxx> Applied, thanks. > --- > drivers/media/video/omap3isp/isp.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/media/video/omap3isp/isp.c > b/drivers/media/video/omap3isp/isp.c index 2a5fbe6..367ced3 100644 > --- a/drivers/media/video/omap3isp/isp.c > +++ b/drivers/media/video/omap3isp/isp.c > @@ -1756,7 +1756,7 @@ static int isp_register_entities(struct isp_device > *isp) goto done; > > /* Register external entities */ > - for (subdevs = pdata->subdevs; subdevs->subdevs; ++subdevs) { > + for (subdevs = pdata->subdevs; subdevs && subdevs->subdevs; ++subdevs) { > struct v4l2_subdev *sensor; > struct media_entity *input; > unsigned int flags; -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html