On Thu, Jun 2, 2011 at 8:36 AM, Steve Sakoman <sakoman@xxxxxxxxx> wrote: > On Fri, May 6, 2011 at 6:17 AM, Lesly A M <leslyam@xxxxxx> wrote: >> Patch series for TWL4030 power scripts for OMAP3 boards and >> workaround for TWL erratum 27. >> >> Changes for implementing TWL4030 power scripts recommended by hardware team. >> Introduced a new TWL4030 power script file, which can be used by different >> OMAP3 board with the power companion chip TWL4030. >> >> Updated the changes for TWL4030 errata 27 & 28, and modified >> the TWL4030 power script. >> Workaround for TWL4030 erratum 27 is required for Si version less than or >> equal to TWL5030 ES1.1. >> >> TWL4030 script changes re-based on Kevin's PM tree in pm branch. >> >> This patch series have a dependency with the patch: >> http://www.spinics.net/lists/linux-omap/msg50547.html >> >> Changes in v7: >> changes to fix Nishanth Menon's comments >> i) Added the workaround for TWL4030 Erratum 27 >> >> split the first patch in v6 >> i) fix for twl4030 script load >> ii) correct the warning print during script loading >> >> Added new patch files >> i) changing sys_off signal polarity >> >> Changes in v8: >> updated the change logs >> moving the TWL IDCODE checking to twl-core.c >> >> Changes in V9: >> changes to fix David Derrick's comments >> i) turn OFF the NRES_PWRON resource in warm reset sequence >> ii) optimize the i2c writes during resource configuration >> >> Changes in V10: >> changes for Tony's comments >> i) making the TWL4030 power scripts loadable module >> >> Since the voltage layer is evolving to a new design, the voltage dependant >> changes required for the TWL4030 script are not incorporated in the patch series. >> So this TWL4030 script patch series can be tested with a separate patch for >> voltage layer changes. >> >> link: http://pastebin.mozilla.org/1219625 >> >> This changes are tested on OMAP3430 & OMAP3630 SDP with off mode enabled in suspend path. >> Tested with suspend/resume script, which will test system suspend in a loop. >> Tested for more than 1000 iterations. >> Also tested the reboot with WRM_RST button & reboot command. > > I've tested this series on Overo and it seems to have no effect. > > After 'echo mem > /sys/power/state' my system draws 53mA both with and > without the above patch set. > > Has anyone else confirmed these changes on a platform other than the SDP? I suppose I should add my assumptions in testing: - CONFIG_TWL4030_SCRIPT needs to be turned on in omap2plus_defconfig - no board changes are required Correct assumptions? Steve -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html