Re: [PATCH 3/8] MFD: twl4030-audio: Rename platform data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday 01 June 2011 16:38:23 Tony Lindgren wrote:
> But you could easily remove all the board specific struct
> twl4030_codec_data and struct twl4030_codec_audio_data entries by adding a
> default audio init option to omap_pmic_init for the common configuration.

Yeah, I can grep in the board files, and see what is the most common 
configuration

> How about something like:
> 
> void omap_pmic_init(int bus, u32 clkrate, const char *pmic_type, int
> pmic_irq, struct twl4030_platform_data *pmic_data, u32 flags);

common-board-devices.c has omap_pmic_init, but without the flags.

> Where flags would be TWL_BOARD_HAS_DEFAULT_CODEC etc, and if the entry in
> pmic_data is NULL, just use the default configuration. I think you already
> have the clkrate there?

I'll take a look, should we have new file specifically for twl, or should I 
extend the common-board-devices.c with the twl related things? IMHO a new file 
might be better, since the full twl config might be quite big.

-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux