Re: V 3.0-rc1: [REPORT] OMAP MMC and CONSOLE Regression

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 30, 2011 at 6:03 PM, Santosh Shilimkar
<santosh.shilimkar@xxxxxx> wrote:
> While trying out V3.0-rc1, I noticed couple of regressions. Am
> posting this in case anybody come across same issues.
>
> 1.OMAP MMC code keep throwing "Pbias Voltage is not same as LDO" error
> continuously.
>
> Balaji is planning post right fix for the same, but just
> in case you get around this issue,
>

Hi Santosh,
You can find MMC pbias fix here
http://www.spinics.net/lists/linux-omap/msg51735.html

> diff --git a/arch/arm/mach-omap2/hsmmc.c b/arch/arm/mach-omap2/hsmmc.c
> index b2f30be..94ae400 100644
> --- a/arch/arm/mach-omap2/hsmmc.c
> +++ b/arch/arm/mach-omap2/hsmmc.c
> @@ -145,6 +145,7 @@ static void omap4_hsmmc1_after_set_reg(struct device
> *dev, int slot,
>                                 int power_on, int vdd)
>  {
>        u32 reg;
> +       unsigned long timeout;
>
>        if (power_on) {
>                reg = omap4_ctrl_pad_readl(control_pbias_offset);
> @@ -158,7 +159,14 @@ static void omap4_hsmmc1_after_set_reg(struct device
> *dev, int slot,
>                        OMAP4_USBC1_ICUSB_PWRDNZ_MASK);
>                omap4_ctrl_pad_writel(reg, control_pbias_offset);
>                /* 4 microsec delay for comparator to generate an error*/
> -               udelay(4);
> +               timeout = jiffies + msecs_to_jiffies(500);
> +               do {
> +                       reg = omap4_ctrl_pad_readl(control_pbias_offset);
> +                       if (!(reg & OMAP4_MMC1_PBIASLITE_VMODE_ERROR_MASK))
> +                               break;
> +                       mdelay(1);
> +               } while (!time_after(jiffies, timeout));
> +
>                reg = omap4_ctrl_pad_readl(control_pbias_offset);
>                if (reg & OMAP4_MMC1_PBIASLITE_VMODE_ERROR_MASK) {
>                        pr_err("Pbias Voltage is not same as LDO\n");
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux