Rafael,
On Sat, May 28, 2011 at 11:01 AM, Rafael J. Wysocki <rjw@xxxxxxx> wrote:
> On Saturday, May 28, 2011, Kevin Hilman wrote:
>> Some platforms wish to implement their PM core suspend code as
>> modules. To do so, these functions need to be exported to modules.
>
> Hmm. What happens if the module is not loaded and the user attempts to
> suspend?
In that case suspend_ops is NULL and suspending has no effect
(pm_suspend returns -ENODEV).
Note that this also happens after the module unload.
Is that the expected behavior?
>
> Rafael
Regards,
Jean
>
>
>> Reported-by: Jean Pihet <j-pihet@xxxxxx>
>> Signed-off-by: Kevin Hilman <khilman@xxxxxx>
>> ---
>> Applies against v2.6.39
>>
>> kernel/power/suspend.c | 2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c
>> index 6275970..eca495d 100644
>> --- a/kernel/power/suspend.c
>> +++ b/kernel/power/suspend.c
>> @@ -44,6 +44,7 @@ void suspend_set_ops(const struct platform_suspend_ops *ops)
>> suspend_ops = ops;
>> mutex_unlock(&pm_mutex);
>> }
>> +EXPORT_SYMBOL(suspend_set_ops);
>>
>> bool valid_state(suspend_state_t state)
>> {
>> @@ -65,6 +66,7 @@ int suspend_valid_only_mem(suspend_state_t state)
>> {
>> return state == PM_SUSPEND_MEM;
>> }
>> +EXPORT_SYMBOL(suspend_valid_only_mem);
>>
>> static int suspend_test(int level)
>> {
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
