On Fri, May 27, 2011 at 5:26 PM, Kevin Hilman <khilman@xxxxxx> wrote: > Jean Pihet <jean.pihet@xxxxxxxxxxxxxx> writes: > >> On Fri, May 27, 2011 at 1:02 AM, Kevin Hilman <khilman@xxxxxx> wrote: >>> Remove the OMAP-specific PM debug 'sleep_while_idle' feature which is >>> currently available as an OMAP-specific debugfs entry. >>> >>> This duplicates existing ARM-generic functionality available as a >>> boot-time option using the boot cmdline option 'hohlt'. >> 'nohlt' is only for the default arch idle handler (pm_idle). It does >> not apply to the cpuidle handler (omap3_enter_idle) which depends on >> CONFIG_CPU_IDLE. > > AFAICT, it affects CPUidle also, since CPUidle replaces pm_idle, which > is protected by the hlt_counter check. That is correct, please ignore my comment. > I think the CPUidle folks are looking for a way to replace using > pm_idle though. After that happens, there are a couple options. 1) add > a check for hlt_counter in the CPUidle path, or 2) just disable CPUidle > at Kconfig level. 1) makes sense if the kernel parameter is used to enable/disable idle. > >>> If runtime configuration of this is needed, then adding a debugfs >>> entry for the ARM-generic hlt/nohlt interface should be added. >> Is there a need for it? > > I don't think so. But my point was that if anyone wants this feature > back, this would be the way to add it. > > Kevin > > Jean -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
