Jean Pihet <jean.pihet@xxxxxxxxxxxxxx> writes: > On Fri, May 27, 2011 at 1:02 AM, Kevin Hilman <khilman@xxxxxx> wrote: >> Inspired by Jean's work to move PM code to modules, I decided it's >> time to remove a bunch of ugly and difficult to maintain code from PM >> debug. > Indeed this code is a spaghetti mess and makes pm-debug difficult to > be modularized. > >> The main chunk here is removing the register dump features for >> OMAP2/OMAP3 which are awful to read, and impossible to scale for >> OMAP4+. ÂAlso, there are now some userspace /dev/mem-based tools (like >> omapconf) that can handle this type of thing much better, and with a >> much better interface and display. > > Agree. However we still need the equivalent of [1] to retrieve the > PRCM registers just before and after the WFI instructions. Correct, but as that patch is not upstream, I'm not considering it as support that needs to be maintained. > I would like to propose some replacement when the current code > clean-up is settled down a bit. Great! Kevin > [1] http://git.kernel.org/?p=linux/kernel/git/khilman/linux-omap-pm.git;a=commitdiff;h=5dd36389eb6ef4837a2aad128e4bd0226468c171 > > Regards, > Jean > >> Series applies to v2.6.39. >> >> Kevin Hilman (4): >> ÂOMAP3: PM debug: remove sleep_while_idle feature >> ÂOMAP2: PM debug: remove register dumping >> ÂOMAP3: PM debug: remove register dumping >> ÂOMAP2: PM debug: move wakeup timer into clockevent code >> >> Âarch/arm/mach-omap2/pm-debug.c      Â| Â362 ----------------------------- >> Âarch/arm/mach-omap2/pm.h         Â|  Â9 - >> Âarch/arm/mach-omap2/pm24xx.c       Â|  Â6 +- >> Âarch/arm/mach-omap2/pm34xx.c       Â|  Â6 - >> Âarch/arm/mach-omap2/timer-gp.c      Â|  33 +++- >> Âarch/arm/plat-omap/include/plat/dmtimer.h |  Â1 - >> Â6 files changed, 32 insertions(+), 385 deletions(-) >> >> -- >> 1.7.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-omap" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html >> -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
