On Fri, May 27, 2011 at 1:00 AM, Kevin Hilman <khilman@xxxxxx> wrote: > jean.pihet@xxxxxxxxxxxxxx writes: > >> From: Jean Pihet <j-pihet@xxxxxx> >> >> Provide omap_pm_tick_nohz_get_sleep_length_us so that the code >> from the OMAP PM modules can use it. >> >> Signed-off-by: Jean Pihet <j-pihet@xxxxxx> > > This patch is doing more than mentioned in the changelog. Agree, there is a bit of clean-up/rework as well. Will re-organize. ... > >> +#endif >> + >> +#ifdef CONFIG_NO_HZ >> +unsigned long omap_pm_tick_nohz_get_sleep_length_us(void) >> +{ >> + return ktime_to_us(tick_nohz_get_sleep_length()); >> +} >> +EXPORT_SYMBOL(omap_pm_tick_nohz_get_sleep_length_us); >> +#endif > > Usage of this is OMAP2-specific and needed for this very old, debug-only > interface. > I was inspired by some of what you did in this series, and > will attempt to make your life easier by just removing this code all > together. I just posted a series for that. Only OMAP2 uses it currently but I think it is useful to have the time to next tick available for debug purpose. BTW this change implements it in a more generic way: tick_nohz_get_sleep_length is generic and also used by e.g. cpuidle to determine the next state to enter. Jean -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html