On Thu, May 26, 2011 at 16:15, Kevin Hilman <khilman@xxxxxx> wrote: > Nishanth Menon <nm@xxxxxx> writes: > >> On 14:03-20110526, Premi, Sanjeev wrote: >>> > -----Original Message----- >>> > From: linux-omap-owner@xxxxxxxxxxxxxxx >>> > [mailto:linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of Menon, Nishanth >>> > Sent: Thursday, May 26, 2011 7:27 AM >>> > To: linux-omap >>> > Cc: V, Aneesh; Menon, Nishanth >>> > Subject: [RFC][PATCH 1/9] OMAP: ID: introduce chip detection >>> > for OMAP4460 >>> > >>> > From: Aneesh V <aneesh@xxxxxx> >>> > >>> > Add support for detecting the latest in the OMAP4 family: OMAP4460 >>> > Among other changes, the new chip also can support 1.5GHz A9s, >>> > 1080p stereoscopic 3D and 12 MP stereo (dual camera). In addition, >>> > we have changes to OPPs supported, clock tree etc, hence having a >>> > chip detection is required. >>> > >>> > Starting from OMAP4460 ES1.0, we are moving from HAWKEYE to >>> > Ramp system >>> > for chip identification. Since the bit offsets are the same, >>> > just rename >>> > the variable for dual use. >>> > >>> > For more details on OMAP4460, see >>> > Highlights: >>> > http://focus.ti.com/general/docs/wtbu/wtbuproductcontent.tsp?c >>> > ontentId=53243&navigationId=12843&templateId=6123 >>> > Public TRM is available here as usual: >>> > http://focus.ti.com/general/docs/wtbu/wtbudocumentcenter.tsp?t >>> > emplateId=6123&navigationId=12667 >>> > >>> > [nm@xxxxxx: cleanups and introduction of ramp system] >>> > Signed-off-by: Nishanth Menon <nm@xxxxxx> >>> > Signed-off-by: Aneesh V <aneesh@xxxxxx> >>> > --- >>> > arch/arm/mach-omap2/id.c | 19 ++++++++++++++----- >>> > arch/arm/plat-omap/include/plat/cpu.h | 12 ++++++++++++ >>> > 2 files changed, 26 insertions(+), 5 deletions(-) >>> > >>> > diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c >>> > index 2537090..724be0a 100644 >>> > --- a/arch/arm/mach-omap2/id.c >>> > +++ b/arch/arm/mach-omap2/id.c >>> > @@ -331,7 +331,7 @@ static void __init omap3_check_revision(void) >>> > static void __init omap4_check_revision(void) >>> > { >>> > u32 idcode; >>> > - u16 hawkeye; >>> > + u16 hawkeye_ramp; >>> >>> [sp] Why is this change required? >> As explained in the commit message, using hawkeye will not be accurate >> anymore for 4460 onwards. The variable naming is changed to prevent confusion in >> the future as we continue to use ramp_system. As far as I know, there is >> no unique bit to differentiate between the two and so far have been >> unique. > > So if the register is the same, and all the bit offsets are the same, > what has changed? IOW, if there's no difference to the SW, then the > variable rename is probably superfluous, and could be covered by a > comment in the code. OK. that'd be easier - I agree. Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
