On Wed, May 25, 2011 at 04:38:50PM -0700, Nishanth Menon wrote:
> By creating freq_table_[alloc|free] we can handle the differences
> between OMAP2 and OMAP3+ systems and we have a centralized allocation
> and cleanup strategy. We use this to cleanup the freq_table when
> cpufreq_frequency_table_cpuinfo fails.
>
> Signed-off-by: Nishanth Menon <nm@xxxxxx>
> ---
...
> static int __cpuinit omap_cpu_init(struct cpufreq_policy *policy)
> {
> int result = 0;
> @@ -167,21 +187,22 @@ static int __cpuinit omap_cpu_init(struct cpufreq_policy *policy)
> return -EINVAL;
>
> policy->cur = policy->min = policy->max = omap_getspeed(policy->cpu);
> - if (use_opp)
> - opp_init_cpufreq_table(mpu_dev, &freq_table);
> - else
> - clk_init_cpufreq_table(&freq_table);
>
> - if (!freq_table) {
> - dev_err(mpu_dev, "%s: cpu%d: unable to allocate freq table\n",
> - __func__, policy->cpu);
> - return -ENOMEM;
> + result = freq_table_alloc();
> + if (result || !freq_table) {
> + dev_err(mpu_dev, "%s: cpu%d: unable to get freq table [%d]\n",
> + __func__, policy->cpu, result);
> + return result;
The "|| !freq_table" isn't needed, and technically allows the code to
return zero for an error return if the subexpression does evaluate
true.
Todd
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
