On Wed, May 25, 2011 at 17:51, Todd Poynor <toddpoynor@xxxxxxxxxx> wrote:
>
>> + if (!freq_table) {
>> + dev_err(mpu_dev, "%s: cpu%d: no freq table!\n", __func__,
>> + policy->cpu);
>
> Just a minor comment: suggest dev_dbg() or WARN_ONCE() for some of
> these conditions that may be frequently evaluated and probably won't
> be cleared up after being hit once.
This is an error because we dont expect it as far as the device is
concerned. I'd use a debug/warn if I can recover out of it and
continue functionality.
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
