Hi Santosh, On Thu, May 19, 2011 at 10:04 AM, Santosh Shilimkar <santosh.shilimkar@xxxxxx> wrote: > On 5/18/2011 11:02 PM, jean.pihet@xxxxxxxxxxxxxx wrote: >> >> From: Jean Pihet<j-pihet@xxxxxx> >> >> Provide the the assembly function v7_flush_dcache_all to the >> OMAP3 PM module, under CONFIG_CPU_V7. >> v7_flush_dcache_all is used by the low level sleep code. >> >> Signed-off-by: Jean Pihet<j-pihet@xxxxxx> >> --- >> arch/arm/mach-omap2/pm.c | 4 ++++ >> arch/arm/mach-omap2/pm.h | 4 ++++ >> 2 files changed, 8 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c >> index 2e43fd6..ab69c5a 100644 >> --- a/arch/arm/mach-omap2/pm.c >> +++ b/arch/arm/mach-omap2/pm.c >> @@ -325,6 +325,10 @@ unsigned long >> omap_pm_tick_nohz_get_sleep_length_us(void) >> EXPORT_SYMBOL(omap_pm_tick_nohz_get_sleep_length_us); >> #endif >> >> +#ifdef CONFIG_CPU_V7 >> +EXPORT_SYMBOL(v7_flush_dcache_all); >> +#endif >> + > > You have already mentioned, this export is wrong and indeed it > is wrong. You can use "flush_cache_all()" instead here which will > pick the right asm function. I could not find a usable flush cache function that is exported for use by the modules. I will re-submit the next version of the patches and specifically ask about it on l-a-k ML as well. >The downside is it will invalidate > I cache as well but that's ok because it's get invalidated anyways > in wakeup path. That should be ok. > > Regards > Santosh > Thanks, Jean -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
