On 05/23/11 10:47, Laurent Pinchart wrote:
> Hi Javier,
>
> On Monday 23 May 2011 09:25:01 javier Martin wrote:
>> On 22 May 2011 15:49, Igor Grinberg <grinberg@xxxxxxxxxxxxxx> wrote:
> [snip]
>
>>>> @@ -309,6 +357,15 @@ static int beagle_twl_gpio_setup(struct device
>>>> *dev, pr_err("%s: unable to configure EHCI_nOC\n", __func__); }
>>>>
>>>> + if (omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XM) {
>>>> + /*
>>>> + * Power on camera interface - only on pre-production, not
>>>> + * needed on production boards
>>>> + */
>>>> + gpio_request(gpio + 2, "CAM_EN");
>>>> + gpio_direction_output(gpio + 2, 1);
>>> Why not gpio_request_one()?
>> Just to follow the same approach as in the rest of the code.
>> Maybe a further patch could change all "gpio_request()" uses to
>> "gpio_request_one()".
> Please do it the other way around. Replace calls to gpio_request() +
> gpio_direction_output() with a call to gpio_request_one(), and then modify
> this patch to use gpio_request_one().
Well, this is done already, you need to follow Tony's linux-next branch...
So, just changing this patch would do...
Also, good practice is to base patches on maintainer's appropriate branch,
so it would be easier to apply.
--
Regards,
Igor.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
