Hi Lesly, On Tue, May 17, 2011 at 07:10:03PM +0530, Manuel, Lesly Arackal wrote: > Hi Samuel, > > On Sat, May 14, 2011 at 12:09 AM, Samuel Ortiz <sameo@xxxxxxxxxxxxxxx> wrote: > > Hi Lesly, > > > > On Fri, May 06, 2011 at 06:47:10PM +0530, Lesly A M wrote: > >> Power bus message sequence for TWL4030 to enter sleep/wakeup/warm_reset. > >> > >> TWL4030 power scripts which can be used by different OMAP3 boards > >> with the power companion chip (TWL4030 series). > >> > >> The twl4030 generic script can be used by any board file to update > >> the power data in twl4030_platform_data. > >> > >> Since the TWL4030 power script has dependency with APIs in twl4030-power.c > >> removing the __init for these APIs. > >> > >> For more information please see: > >> http://omapedia.org/wiki/TWL4030_power_scripts > > I understand you guys are trying to keep the arch/arm stats to a sane level, > > but I don't see why this driver should be under drivers/mfd/. I'm usually > > flexible about what goes into drivers/mfd, but this one seems out of context > > to me. > > Since this script driver file contains the changes for PM IC (TWL4030 series), > which is a Multifunction devices with GPIOs, USB, audio, > current regulators, power management chip, ... > > This script driver file contains the pm bus message sequence which will be > programmed in the scratch memory of the PM IC, and some resource configuration > data for PM IC resources. > > This change was suggested by Tony for the last version of this patch series. I understand, but I'm trying to get the "let's push everything that somehow linked to our MFD driver to drivers/mfd/" crazyness down to a sane level. This one doesn't look like it should be part of drivers/mfd. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html