On Wed, May 18, 2011 at 03:34, Tony Lindgren <tony@xxxxxxxxxxx> wrote: > * Menon, Nishanth <nm@xxxxxx> [110518 11:03]: >> On Wed, May 18, 2011 at 02:59, Tony Lindgren <tony@xxxxxxxxxxx> wrote: >> > * Nishanth Menon <nm@xxxxxx> [110518 08:13]: >> >> Kevin's patch: >> >> OMAP3+: voltage: remove unneeded debugfs interface >> >> >> >> removed ability to check the voltages in the domains. >> >> This puts a crunch on validation we can do, hence we >> >> re-introduce them back in >> > >> >> Signed-off-by: Nishanth Menon <nm@xxxxxx> >> >> --- >> >> arch/arm/mach-omap2/voltage.c | 66 +++++++++++++++++++++++++++++++++++++++++ >> >> arch/arm/mach-omap2/voltage.h | 1 + >> >> 2 files changed, 67 insertions(+), 0 deletions(-) >> > >> > Hmm, this seems to be adding the debug code instead? >> >> Yes, we need some interface to know what the current voltages are for >> each of the domain when verifying if dvfs is actually scaling voltage >> or not. the other option is to use omapconf (not yet public and only >> supports OMAP4) to see what the voltages are. Though omapconf is an >> option, it shows what it's computation of voltage from vsel is, not >> what the kernel internally thinks (vsel_uv functions) it is. > > I guess I just got confused reading the patch description.. sorry - will fix it up for v3 after waiting for further comments - and if Sanjeev is ok, will wrap it up under #ifdefs for DEBUG_FS as well to prevent !DEBUGFS builds.. Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
