On Thu, May 12, 2011 at 14:16, Premi, Sanjeev <premi@xxxxxx> wrote: [...] >> > This patch fixes these errors by enclosing code related to debugfs >> > in #ifdef CONFIG_DEBUG_FS..#endif. >> >> generic - couple of comments - I think the #defs should be isolated >> off to headers - maybe the right approach may be to move the debugfs > > [sp] None of the code encapsulated here is "header" material. > I guess you have seen the patch below. > >> entries off to a separate file? or pm-debug.c?? > > [sp] I wish it was all debug code. It is "operational" code. > Check the Kconfig in plat-omap. Smartreflex is not even expected > to work without debugfs. Though I believe much of the data put in > debugfs can be in local lists/structures. > > That was supposed to be my next set of patches - as I understand > the implementation better. [...] >> Could I suggest Kevin's volt cleanup series - based off _c branch if >> there are cleanups to be done? > > [sp] I didn't see it updated for 5 weeks. hence used this. > but patch should apply cleanly... While cleaning up voltdm_c set earlier this week, I think your changes apply better there. btw, I could incorporate a bit of your code into my patch, esp the one Tony commented on http://marc.info/?l=linux-omap&m=130570559515977&w=2 but, overall, on the topic of SR, either: a) move SR autocomp into sysfs (and dump the rest of the debugfs - it is useful for validation, but does'nt really provide additional info) - given that it used to reside in /sys/power/sr_vddx_autocomp and then moved to debugfs, I am not sure if this is the right path b) move SR autocomp into a board defined configuration.. more intrusive, but folks would really want to enable SR as an option at times from userspace - many distros and devices do this (e.g. N900).. Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
